-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gRPC interface support #32
Conversation
892cc79
to
1196726
Compare
Minimum allowed coverage is Generated by 🐒 cobertura-action against cc09d98 |
2a318f7
to
f8f53f0
Compare
961e44d
to
4c53ea0
Compare
2da8700
to
d119b53
Compare
667a473
to
1abb8ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to be too picky but some docstrings could be added on some functions - i would leave this up to you.
4fdd129
to
4fc45d3
Compare
4fc45d3
to
cdf3803
Compare
06d35c5
to
173bfc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First findings
Co-authored-by: BjoernAtBosch <Bjoern.Hornburg@de.bosch.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more findings/small improvements
grpc-interface-support/templates/cpp/ServiceNameServiceFactory.h
Outdated
Show resolved
Hide resolved
grpc-interface-support/templates/cpp/ServiceNameServiceFactory.h
Outdated
Show resolved
Hide resolved
Co-authored-by: BjoernAtBosch <Bjoern.Hornburg@de.bosch.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds support for the functional interface type
grpc-interface
.With this, gRPC service client SDKs are generated which are auto-addedas a dependencies whenever an app has a required interface of such a type ´.