Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gRPC interface support #32

Merged
merged 20 commits into from
Sep 15, 2023
Merged

feat: gRPC interface support #32

merged 20 commits into from
Sep 15, 2023

Conversation

doosuu
Copy link
Member

@doosuu doosuu commented Aug 29, 2023

Adds support for the functional interface type grpc-interface.
With this, gRPC service client SDKs are generated which are auto-addedas a dependencies whenever an app has a required interface of such a type ´.

@doosuu doosuu force-pushed the grpc-interface-support branch 2 times, most recently from 892cc79 to 1196726 Compare August 29, 2023 11:50
@github-actions
Copy link

github-actions bot commented Aug 29, 2023

File Coverage Lines Branches
All files 25% 41% 9%
sdk-installer/src/run.py 19% 29% 9%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against cc09d98

@doosuu doosuu force-pushed the grpc-interface-support branch 2 times, most recently from 2a318f7 to f8f53f0 Compare August 30, 2023 06:55
@doosuu doosuu changed the title Grpc interface support gRPC interface support Aug 30, 2023
@doosuu doosuu force-pushed the grpc-interface-support branch 11 times, most recently from 961e44d to 4c53ea0 Compare September 3, 2023 07:32
@doosuu doosuu marked this pull request as ready for review September 8, 2023 10:13
@doosuu doosuu force-pushed the grpc-interface-support branch 12 times, most recently from 2da8700 to d119b53 Compare September 11, 2023 08:47
Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to be too picky but some docstrings could be added on some functions - i would leave this up to you.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
grpc-interface-support/src/cpp.py Outdated Show resolved Hide resolved
grpc-interface-support/src/python.py Show resolved Hide resolved
sdk-installer/src/run.py Outdated Show resolved Hide resolved
@doosuu doosuu changed the title gRPC interface support feat: gRPC interface support Sep 14, 2023
Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First findings

grpc-interface-support/README.md Outdated Show resolved Hide resolved
grpc-interface-support/src/conan_helper.py Outdated Show resolved Hide resolved
grpc-interface-support/src/conan_helper.py Outdated Show resolved Hide resolved
grpc-interface-support/src/conan_helper.py Outdated Show resolved Hide resolved
doosuu and others added 2 commits September 14, 2023 22:15
Co-authored-by: BjoernAtBosch <Bjoern.Hornburg@de.bosch.com>
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more findings/small improvements

sdk-installer/README.md Outdated Show resolved Hide resolved
sdk-installer/requirements.txt Show resolved Hide resolved
sdk-installer/src/run.py Outdated Show resolved Hide resolved
setup/README.md Show resolved Hide resolved
vehicle-model-lifecycle/README.md Show resolved Hide resolved
doosuu and others added 3 commits September 15, 2023 13:02
Co-authored-by: BjoernAtBosch <Bjoern.Hornburg@de.bosch.com>
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doosuu doosuu merged commit 086bc4e into main Sep 15, 2023
14 checks passed
@doosuu doosuu deleted the grpc-interface-support branch September 15, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants